UPSTREAM: 30717: fix oc describe suggestion in oc rsh output #10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
e10aeba to
0ad5e76
Compare
|
[test] |
|
LGTM, @juanvallejo make sure you open the upstream PR. @liggitt minor one. |
Will do! |
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
0ad5e76 to
5c58670
Compare
juanvallejo
changed the title
|
re[test] |
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
5c58670 to
7082805
Compare
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
7082805 to
aa62703
Compare
|
re[test] |
|
@fabianofranz PTAL |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (Image: devenv-rhel7_5179) |
|
conformance test flaked on #9548 re[test] |
openshift-bot
added
the
needs-rebase
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
aa62703 to
83f1778
Compare
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
`oc rsh <podname>` outputs the line `defaulting container name to <podname_top_level_container>, use ' describe po/<podname>' cmd to see all containers in this pod`; however this suggestion is missing the root command (oc, kube, openshift cli ...) before `describe po/<podname>`. This patch adds the root command used to invoke the `rsh` command to this suggestion. `$ openshift cli rsh <podname>` ``` defaulting container name to idling-tcp-echo, use 'openshift cli describe po/<podname>' to see all containers in this pod ```
juanvallejo
force-pushed
the
jvallejo_fix-oc-describe-suggestion-in-oc-rsh
branch
from
83f1778 to
601285a
Compare
|
Evaluated for origin test up to 601285a |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10031/) (Base Commit: 66a729c) |
|
continuous-integration/openshift-jenkins/test SUCCESS |
openshift-bot
removed
the
needs-rebase
|
[merge] |
|
Evaluated for origin merge up to 601285a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPSTREAM PR: kubernetes/kubernetes#30717
oc rsh <podname>outputs the linedefaulting container name to <podname_top_level_container>, use ' describe po/<podname>' cmd to see all containers in this pod; however this suggestion is missing the rootcommand (oc, kube, openshift cli ...) before
describe po/<podname>.This patch adds the root command used to invoke the
rshcommand tothis suggestion.
$ openshift cli rsh <podname>cc @fabianofranz