Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move unrelated extended tests out of images #10520

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Aug 18, 2016

  • create a different folder imageapis
  • move limitrange_admission and quote_admission tests out
  • change tags to imageapis

* create a different folder imageapis
* move limitrange_admission and quote_admission tests out
* change tags to imageapis
@bparees
Copy link
Contributor Author

bparees commented Aug 18, 2016

@PI-Victor i had to update extended_tests.go also because of the package change, so i'm redoing your PR here.

@bparees
Copy link
Contributor Author

bparees commented Aug 18, 2016

[testextended][extended:core(imageapis)]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 8d1cc20

@PI-Victor
Copy link
Contributor

@bparees i was waiting on the tests to see what fails. at least i see what i missed :) didn't know that's where we load the tests.

@bparees
Copy link
Contributor Author

bparees commented Aug 18, 2016

i was waiting on the tests to see what fails. at least i see what i missed :) didn't know that's where we load the tests.

right, well the tests failed because the ginkgo filter didn't find any matches to "imageapis" because of the missing line i added. thanks to @stevekuznetsov for telling me what was wrong.

of course the tests are still going to fail (which is why we started down this road in the first place), but at least we'll see that they are runnable.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/433/) (Extended Tests: core(imageapis))

@bparees
Copy link
Contributor Author

bparees commented Aug 18, 2016

in this case failure means success, so [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 18, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8216/) (Image: devenv-rhel7_4875)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8d1cc20

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@bparees
Copy link
Contributor Author

bparees commented Aug 18, 2016

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8d1cc20

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8209/)

@openshift-bot openshift-bot merged commit e5178ec into openshift:master Aug 19, 2016
@bparees bparees deleted the move_imageapi_tests branch August 22, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants