Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset tests broken - URI is not defined errors #6651

Closed
jwforres opened this issue Jan 13, 2016 · 8 comments
Closed

Asset tests broken - URI is not defined errors #6651

jwforres opened this issue Jan 13, 2016 · 8 comments
Labels
component/web kind/test-flake Categorizes issue or PR as related to test flakes. priority/P2

Comments

@jwforres
Copy link
Member

Getting errors like:

1)  unauthenticated user should be able to log in
  - UnknownError: unknown error: [$injector:modulerr] Failed to instantiate module openshiftConsole due to:
ReferenceError: URI is not defined

Seems to be on every test/merge that makes it to asset e2e tests

@liggitt @spadgett in case you can investigate before I can

@jwforres jwforres added component/web priority/P1 kind/test-flake Categorizes issue or PR as related to test flakes. labels Jan 13, 2016
@jwforres
Copy link
Member Author

Last PR that merged had no ui changes, so I suspect it is some npm or bower dep that has been modified and wasn't version locked

@csrwng
Copy link
Contributor

csrwng commented Jan 14, 2016

My PR has no UI changes and it's failing with the same error

@spadgett
Copy link
Member

I can't reproduce locally clean installing assets.

@liggitt
Copy link
Contributor

liggitt commented Jan 14, 2016

Yeah, the whole queue is affected. I'll look into it in a few minutes if no one else grabs it

@liggitt
Copy link
Contributor

liggitt commented Jan 14, 2016

Maybe the cached installed assets in Jenkins bit us

@jwforres
Copy link
Member Author

Yeah it has to be something specific in Jenkins env because I can't
reproduce it locally either

On Wed, Jan 13, 2016 at 7:52 PM, Jordan Liggitt [email protected]
wrote:

Maybe the cached compiled assets in Jenkins bit us


Reply to this email directly or view it on GitHub
#6651 (comment).

@jwforres
Copy link
Member Author

Confirmed it was a bad base_ami, not sure what exactly caused the URI.js bower_component to only get partially extracted to the file system.

Latest base_ami and devenv_ami are fine so queue should be unblocked now.

@liggitt
Copy link
Contributor

liggitt commented Jan 14, 2016

fixed in https://ci.openshift.redhat.com/jenkins/job/devenv_ami/3143/
tests in openshift/vagrant-openshift#382 should prevent it from happening again

@liggitt liggitt closed this as completed Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web kind/test-flake Categorizes issue or PR as related to test flakes. priority/P2
Projects
None yet
Development

No branches or pull requests

4 participants