Skip to content

Commit

Permalink
extended: cli framework doesn't speak api errors
Browse files Browse the repository at this point in the history
  • Loading branch information
0xmichalis committed Jan 4, 2017
1 parent a5eaf99 commit 1e84805
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/extended/deployments/deployments.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
o "github.com/onsi/gomega"

kapi "k8s.io/kubernetes/pkg/api"
"k8s.io/kubernetes/pkg/api/errors"
"k8s.io/kubernetes/pkg/labels"
"k8s.io/kubernetes/pkg/util/wait"
e2e "k8s.io/kubernetes/test/e2e/framework"
Expand Down Expand Up @@ -300,10 +299,11 @@ var _ = g.Describe("deploymentconfigs", func() {
var out string
pollErr := wait.PollImmediate(100*time.Millisecond, 1*time.Minute, func() (bool, error) {
out, err = oc.Run("get").Args("istag/sample-stream:deployed").Output()
if errors.IsNotFound(err) {
return false, nil
}
if err != nil {
// TODO: It would be nice if the cli framework supported api errors.
if strings.Contains(err.Error(), "not found") {
return false, nil
}
return false, err
}
return true, nil
Expand Down

0 comments on commit 1e84805

Please sign in to comment.