Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - enable PKCE #530

Closed
wants to merge 2 commits into from
Closed

WIP - enable PKCE #530

wants to merge 2 commits into from

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Sep 12, 2016

Switches the web console from using an implicit token flow to using an authorization code flow in combination with PKCE (a hash of a privately held "verifier" is bound to the authorization code, and the original verifier must be presented when exchanging the authorization code for a token).

TODO:

  • tests for crypto pieces
  • find sha256 hash algorithm implemented in javascript
  • switch from plain PKCE to S256 PKCE
  • dist build

@openshift-bot
Copy link

openshift-bot commented Nov 20, 2016

Origin Web Console Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2016
@liggitt
Copy link
Contributor Author

liggitt commented Mar 14, 2017

superceded by #1342 and openshift/origin-web-common#7

@liggitt liggitt closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants