-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release note for OVN-Kubernetes secondary networks #87995
base: enterprise-4.18
Are you sure you want to change the base?
Conversation
🤖 Sat Feb 08 00:23:59 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explain the network configuration sync concept to properly explain the localnet configuration update IMHO.
[id="ocp-release-notes-networking-network-attachment-definition_{context}"] | ||
==== Network attachments support dynamic reconfiguration | ||
|
||
Previously, the `NetworkAttachmentDefinition` CR was immutable. With this release, you can edit an existing `NetworkAttachmentDefinition` CR. Support for editing makes it easier to accommodate changes in the underlying network infrastructure, such as adjusting the MTU of a network interface. You still must restart any workloads that use the network attachment definition for the network changes to take effect for those pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's imperative that we mention the concept of the network being in-sync: let's say you have two NADs that both grant access to the same network (i.e. same network name).
If the configurations on these networks are not in sync, when you restart the workloads, they will not get the updated values. Only once all NADs pointing to the same network are sync'ed - i.e. share the same configuration - will the updated configuration trickle down to the workloads (after a restart).
While the network is not in sync, the behavior is undefined - let's say the control planes restarts while the network is not in sync: we do not have any guarantees over which configuration will be picked up.
@jcaamano FYI ; in case you want to say something further.
@jab-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.18
Issue:
Link to docs preview:
QE review:
Additional information: