Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS#13261: Update the 4.12.72 z-stream RNs #87975

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

tmalove
Copy link
Contributor

@tmalove tmalove commented Feb 3, 2025

Version(s):
4.12

Issue:
OSDOCS-12361

Link to docs preview:
4.12.72

QE review:

  • QE has approved this change.
    QE review is not required for z-stream RNs.

Additional information:
The errata URLs will return 404 until the go-live date of 02/06/25.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2025
@tmalove
Copy link
Contributor Author

tmalove commented Feb 3, 2025

/label branch/enterprise-4.12

Copy link

openshift-ci bot commented Feb 3, 2025

@tmalove: The label(s) /label branch/enterprise-4.12 cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label branch/enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 3, 2025

🤖 Wed Feb 05 01:07:19 - Prow CI generated the docs preview:

https://87975--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html

@tmalove tmalove force-pushed the OSDOCS-13261 branch 2 times, most recently from a79c795 to 646591c Compare February 4, 2025 04:25
@tmalove
Copy link
Contributor Author

tmalove commented Feb 4, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 4, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 4, 2025
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving one comment, otherwise looks good to me.
However, as I am new to peer review squad, please wait for @dfitzmau to review again and for the peer-review-done label before proceeding. Thank you!

[id="ocp-4-12-72-bug-fixes_{context}"]
==== Bug fixes

* Previously, during node reboots, especially during update operations, the node that interacts with the rebooting machine entered a `Ready=Unknown` state for a short amount of time. This situation caused the Control Plane Machine Set Operator to enter an `UnavailableReplicas` condition and then an `Available=false` state. The `Available=false` state triggered alerts that demanded urgent action, but in this case, intervention was only required for a short period of time until the node rebooted. With this release, a grace period for node unreadiness is provided so if a node enters an unready state, the Control Plane Machine Set Operator does not instantly enter an `UnavailableReplicas` condition or an `Available=false` state. (link:https://issues.redhat.com/browse/OCPBUGS-48325[*OCPBUGS-48325*]).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this part:
... triggered alerts that demanded urgent action, but in this case, intervention was only required for a short period of time until the node rebooted.
upon the first reading, it sounded to me as if the urgent action was necessarry, however there was not enough time to react. But when reading the Jira description, I realised it is the opposite, and that we do not need admins to take action. Because of that, I would concider changing the wording a little bit.

I am also trying here to get rid of the repetition and some words to make it more concise, plus I think mentioning that a `Ready=Unknown is entered only for a short period of time is unnecessarry, as I believe it is not the main focus of the issue here. But, of course, I stand corrected if I misunderstood. 👍

Suggested change
* Previously, during node reboots, especially during update operations, the node that interacts with the rebooting machine entered a `Ready=Unknown` state for a short amount of time. This situation caused the Control Plane Machine Set Operator to enter an `UnavailableReplicas` condition and then an `Available=false` state. The `Available=false` state triggered alerts that demanded urgent action, but in this case, intervention was only required for a short period of time until the node rebooted. With this release, a grace period for node unreadiness is provided so if a node enters an unready state, the Control Plane Machine Set Operator does not instantly enter an `UnavailableReplicas` condition or an `Available=false` state. (link:https://issues.redhat.com/browse/OCPBUGS-48325[*OCPBUGS-48325*]).
* Previously, during node reboots, especially during update operations, the node that interacted with the rebooting machine entered a `Ready=Unknown` state. This caused the Control Plane Machine Set Operator to enter an `UnavailableReplicas` condition and an `Available=false` state, which triggered alerts that demanded urgent action. However, manual intervention was not necessary because the condition was resolved when the node rebooted. With this release, a grace period for node unreadiness is provided. Therefore, if a node enters an unready state, the Control Plane Machine Set Operator does not instantly enter an `UnavailableReplicas` condition or an `Available=false` state. (link:https://issues.redhat.com/browse/OCPBUGS-48325[*OCPBUGS-48325*]).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions, @eromanova97 . I'd drop "Therefore" to cut down on transitional phrases. The original sentence seems to suggest that a short window of time was available for manual intervention (until the node rebooted). I agree with cutting down on repetition.

@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 4, 2025
Copy link

openshift-ci bot commented Feb 5, 2025

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmalove
Copy link
Contributor Author

tmalove commented Feb 6, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2025
@mburke5678 mburke5678 merged commit fdaaac2 into openshift:enterprise-4.12 Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants