-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-45186: Issue in file virt-configuring-storage-profile.adoc #87971
base: main
Are you sure you want to change the base?
CNV-45186: Issue in file virt-configuring-storage-profile.adoc #87971
Conversation
@sbeskin-redhat: This pull request references CNV-45186 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon Feb 03 18:44:51 - Prow CI generated the docs preview: https://87971--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/storage/virt-configuring-storage-profile.html |
@sbeskin-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sbeskin-redhat: This pull request references CNV-45186 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aglitke Please review this PR. |
---- | ||
<1> `Claim Property Sets` is an ordered list of `AccessMode`/`VolumeMode` pairs, which describe the PVC modes that will be used to provision VM disks. | ||
<2> The `Clone Strategy` line indicates the clone strategy to be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to any documentation that describes the three different cloning strategies (snapshot, csi-clone, copy)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aglitke But the only place in the documentation where the three cloning strategies are described is in this section ("Setting a default cloning strategy using a storage profile").
Resolves: https://issues.redhat.com/browse/CNV-45186
OCP 4.16+
CNV 4.16+
Preview: https://87971--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/storage/virt-configuring-storage-profile.html#virt-customizing-storage-profile-default-cloning-strategy_virt-configuring-storage-profile