Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#43809: Clarifying what's created for each service account #87965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS#43809: Clarifying what's created for each service account #87965

wants to merge 1 commit into from
+13 −19

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Feb 3, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2025
@ocpdocs-previewbot
Copy link

🤖 Mon Feb 03 13:36:21 - Prow CI generated the docs preview:

https://87965--ocpdocs-pr.netlify.app/openshift-dedicated/latest/authentication/understanding-and-creating-service-accounts.html
https://87965--ocpdocs-pr.netlify.app/openshift-dedicated/latest/authentication/using-service-accounts-in-applications.html
https://87965--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/understanding-and-creating-service-accounts.html
https://87965--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/using-service-accounts-in-applications.html
https://87965--ocpdocs-pr.netlify.app/openshift-rosa/latest/authentication/understanding-and-creating-service-accounts.html
https://87965--ocpdocs-pr.netlify.app/openshift-rosa/latest/authentication/using-service-accounts-in-applications.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 3, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer bergerhoffer added this to the Continuous Release milestone Feb 3, 2025
@bergerhoffer
Copy link
Contributor Author

@sanchezl Can you please review?

https://87965--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/understanding-and-creating-service-accounts#service-accounts-overview_understanding-service-accounts

@bergerhoffer
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 3, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 3, 2025
eromanova97
eromanova97 reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added just very small considerations, otherwise looks good to me!
However, please wait for the review of @dfitzmau and the peer-review-done label as I am new to peer review squad.
Thank you!

modules/service-accounts-overview.adoc Show resolved Hide resolved
modules/service-accounts-creating.adoc Show resolved Hide resolved
sanchezl
sanchezl approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 4, 2025
@dfitzmau
Copy link
Contributor

dfitzmau commented Feb 4, 2025

Excellent work @eromanova97 . LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova97 eromanova97 eromanova97 left review comments

@dfitzmau dfitzmau dfitzmau approved these changes

@sanchezl sanchezl sanchezl approved these changes

Assignees

@sanchezl sanchezl

Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
5 participants
@bergerhoffer @ocpdocs-previewbot @eromanova97 @dfitzmau @sanchezl