-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-11309: hardcoded 4.18 version number bump #87963
base: main
Are you sure you want to change the base?
Conversation
@sheriff-rh: This pull request references OSDOCS-11309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sheriff-rh: This pull request references OSDOCS-11309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
49ec7ee
to
e8fd59e
Compare
🤖 Mon Feb 03 13:32:13 - Prow CI generated the docs preview: |
@@ -38,5 +38,5 @@ include::modules/verifying-the-assumed-iam-role-in-your-pod.adoc[leveloffset=+2] | |||
* For more information about installing and using the AWS Boto3 SDK for Python, see the link:https://boto3.amazonaws.com/v1/documentation/api/latest/index.html[AWS Boto3 documentation]. | |||
|
|||
ifdef::openshift-rosa,openshift-dedicated[] | |||
* For general information about webhook admission plugins for OpenShift, see link:https://docs.openshift.com/container-platform/4.17/architecture/admission-plug-ins.html#admission-webhooks-about_admission-plug-ins[Webhook admission plugins] in the OpenShift Container Platform documentation. | |||
* For general information about webhook admission plugins for OpenShift, see link:https://docs.openshift.com/container-platform/4.18/architecture/admission-plug-ins.html#admission-webhooks-about_admission-plug-ins[Webhook admission plugins] in the OpenShift Container Platform documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{product-title}' rather than the plain text product term 'OpenShift Container Platform', unless your use case is an exception.
@@ -29,4 +29,4 @@ include::modules/registry-configuring-registry-storage-rhodf-cephfs.adoc[levelof | |||
== Additional resources | |||
|
|||
* xref:../../scalability_and_performance/optimization/optimizing-storage.adoc#optimizing-storage[Recommended configurable storage technology] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.17/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.18/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
@@ -30,4 +30,4 @@ include::modules/registry-configuring-registry-storage-rhodf-cephfs.adoc[levelof | |||
== Additional resources | |||
|
|||
* xref:../../scalability_and_performance/optimization/optimizing-storage.adoc#optimizing-storage[Recommended configurable storage technology] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.17/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.18/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
@@ -18,5 +18,5 @@ include::modules/registry-configuring-registry-storage-rhodf-cephfs.adoc[levelof | |||
[role="_additional-resources"] | |||
== Additional resources | |||
|
|||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.17/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.18/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
@@ -31,4 +31,4 @@ include::modules/registry-configuring-registry-storage-rhodf-cephfs.adoc[levelof | |||
== Additional resources | |||
|
|||
* xref:../../scalability_and_performance/optimization/optimizing-storage.adoc#optimizing-storage[Recommended configurable storage technology] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.17/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] | |||
* link:https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation/4.18/html-single/managing_and_allocating_storage_resources/index#configuring-image-registry-to-use-openshift-data-foundation_rhodf[Configuring Image Registry to use OpenShift Data Foundation] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{rh-storage}' rather than the plain text product term 'OpenShift Data Foundation', unless your use case is an exception.
@sheriff-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@sheriff-rh: This pull request references OSDOCS-11309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -17,7 +17,7 @@ The CCO uses the `admin` credential to process the `CredentialsRequest` objects | |||
With mint mode, each cluster component has only the specific permissions it requires. | |||
Cloud credential reconciliation is automatic and continuous so that components can perform actions that require additional credentials or permissions. | |||
|
|||
For example, a minor version cluster update (such as updating from {product-title} 4.16 to 4.17) might include an updated `CredentialsRequest` resource for a cluster component. | |||
For example, a minor version cluster update (such as updating from {product-title} {ocp-nminus1} to {product-version}) might include an updated `CredentialsRequest` resource for a cluster component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤓 AWESOME 🎉
How far back do these attributes exist? I would like to backport them 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the HCP files LGTM. Thanks, @sheriff-rh!
Version(s):
4.18+
Issue:
https://issues.redhat.com/browse/OSDOCS-11309
Link to docs preview:
Mon Feb 03 13:32:13 - Prow CI generated the docs preview:
87963--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
QE review:
This PR bumps hard coded version numbers; no SME/QE review required.
Additional information:
Touches a lot of distributions and associated projects.