Revert back to hostnamectl and previous default of not setting hostname #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
CC: @detiber |
|
@sdodson note that the hostname module SHOULD work on atomic host, once we have ansible 2.4. |
michaelgugino
approved these changes
Sep 8, 2017
michaelgugino
previously approved these changes
Sep 8, 2017
The old default was "{{ not openshift.common.version_gte_3_1_or_1_1 }}"
just default to false instead, master branch will never be used with 3.0
hostname module doesn't work on atomic host
Fixes BZ 1489913
thanks, amended my comment with a link to that |
michaelgugino
approved these changes
Sep 8, 2017
|
aos-ci-test |
1 similar comment
|
aos-ci-test |
|
[test] |
|
Evaluated for openshift ansible test up to f255cca |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/638/) (Base Commit: 69f0384) (PR Branch Commit: f255cca) |
|
did positive and negative testing locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old default was "{{ not openshift.common.version_gte_3_1_or_1_1 }}"
just default to false instead, master branch will never be used with 3.0
hostname module doesn't work on atomic host
Fixes BZ 1489913