tox tests: pin test requirement versions #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests started failing once ansible 2.3 was released. It seems wise to pin the dependencies to particular versions until we make a conscious decision to change them (and have tested with them).
|
@stevekuznetsov can travis test this fix for the build? |
|
I kicked off https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible_tox/54/console to check it in jenkins though |
|
Looks like travis was running, and succeeded. |
|
succeeded in Jenkins too. |
|
aos-ci-test |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 2 |
|
Evaluated for openshift ansible merge up to 20fccf7 |
|
[test]ing while waiting on the merge queue |
|
I think this may have caused #3914 to fail tests earlier? |
|
@rikkuness yes this killed that |
|
@stevekuznetsov nice one, thought I'd broke something for a second :) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests started failing once ansible 2.3 was released. It seems wise to
pin the dependencies to particular versions until we make a conscious
decision to change them (and have tested with them).