[nuage_master] Adding module calls instead of command for idempotency. #3905
Conversation
|
I'm unsure how to test these changes as I'm not familiar with nuage. Please test or let me know how so I can test. Thanks. https://trello.com/c/ZPIwuaDr/373-2-idempotency-configure-role-user-permissions |
mtnbikenc
changed the title
|
testing now |
|
Testing byo/config.yml with |
|
@vishpat, would you remind reviewing/testing these changes? |
|
aos-ci-test |
|
Testing nuage has turned out to be a bit more complicated. I'll try to get this tested tomorrow. |
|
@sdodson after reviewing the docs for Nuage, I'm not sure where to find RPMs for running the install. Ideas on where I could find those, or is there a contact for someone more familiar with testing this component? |
|
@mtnbikenc @kwoodson -- @vishpat would know best. I'm fine with leaving this open until they're able to test. |
| command: > | ||
| {{ openshift.common.client_binary }} adm {{item}} | ||
| --config={{ nuage_tmp_conf }} | ||
| delegate_to: "{{ nuage_ca_master }}" |
There was a problem hiding this comment.
Maybe put this at the end of the Configure role/user permissions so it aligns with the remaining tasks.
There was a problem hiding this comment.
I can move it if it is aesthetically pleasing.
| namespace: default | ||
| resource_name: "{{ item.resource_name }}" | ||
| resource_kind: "{{ item.resource_kind }}" | ||
| user: "{{ item.user }}" | ||
| with_items: "{{nuage_tasks}}" |
There was a problem hiding this comment.
s/"{{nuage_tasks}}"/"{{ nuage_tasks }}"
There was a problem hiding this comment.
I can change this but was not in my original PR.
| @@ -23,4 +23,6 @@ nuage_master_crt_dir: /usr/share/nuage-openshift-monitor | |||
| nuage_service_account: system:serviceaccount:default:nuage | |||
|
|
|||
| nuage_tasks: | |||
| - policy add-cluster-role-to-user cluster-reader {{ nuage_service_account }} | |||
| - resource_kind: cluster-role | |||
There was a problem hiding this comment.
Valid value based on [1]:
resource_kind:
description:
- The kind of policy to affect
required: true
default: None
choices: ["role", "cluster-role", "scc"]
aliases: []
|
@sdodson, what do you think about merging this so we don't lose the effort? Do the tests run against nuage? |
No description provided.