-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate wildcard router certificate #3749
Generate wildcard router certificate #3749
Conversation
Can one of the admins verify this patch?
|
1dc2510
to
944a918
Compare
Conditioned on openshift_hosted_router_create_certificate=true. Covers *.{{openshift_master_default_subdomain}}, in particular makes hawkular-metrics route have good cert out of the box.
944a918
to
cef331b
Compare
cef331b
to
e8aeeef
Compare
@mtnbikenc @detiber can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enoodle @mtnbikenc
Would prefer to move the cert generation to an include in order to keep the logic in the main router.yml the same and accomplish the same goal by setting fact in the included tasks. Something like this:
If you'd prefer that I close this PR and open another against my branch we can.
if proc.returncode == 0: | ||
regex = re.compile(r"^\s*X509v3 Subject Alternative Name:\s*?\n\s*(.*)\s*\n", re.MULTILINE) | ||
match = regex.search(x509output) # E501 | ||
if not match: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes need to make it into the src file as the module file (the file under /library/
) is autogenerated.
Then you can call roles/lib_openshift/src/generate.py
to rebuild the lib_openshift/library/
code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these changes under my branch.
@kwoodson I need this change to allow SSO to Kibana from ManageIQ. In ManageIQ we ask the user to give us the main Openshift CA if he wants to authenticate with it. If the router's certificates do not include a wildcard to use with the logging routes, ManageIQ won't be able to authenticate the router through it and we won't be able to securely initiate the SSO. I would be happy for you to take over with your branch. You seem to know your way around here better than I do :) |
@enoodle, I can take this over.
In theory the set_fact in the wildcard router task include sets the |
Conditioned on openshift_hosted_router_create_certificate=true.
Covers *.{{openshift_master_default_subdomain}},
in particular makes hawkular-metrics route have good cert out of the box.
resubmitting of #3226