Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #35

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Update README.md #35

merged 1 commit into from
Apr 15, 2021

Conversation

hlipsig
Copy link
Contributor

@hlipsig hlipsig commented Apr 14, 2021

Build.sh and init.sh should be swapped as init is required to make the dependencies for build.

@hlipsig
Update README.md
31ddc9d 
Build.sh and init.sh should be swapped as init is required to make the dependencies for build.
@mrbarge
Copy link
Contributor

mrbarge commented Apr 15, 2021

Hit this same thing when walking someone else through installing ocm-container this week - agree on switching the order.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@georgettica georgettica merged commit d39f601 into openshift:master Apr 15, 2021
@georgettica
Copy link
Contributor

If you LGTM then it's good enough for me to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewandersonnz drewandersonnz Awaiting requested review from drewandersonnz

@georgettica georgettica Awaiting requested review from georgettica

Assignees

@mrbarge mrbarge

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlipsig @mrbarge @georgettica @openshift-ci-robot