-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a minimal target for ocm-container-minimal #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reorders the Container file to add an ocm-contianer-minimal build target consisting of the base backplane-tools install. This includes a couple of other small reorder changes that should allow for more caching during local builds for quicker and easier testing, particularly of the backplane-tools install steps and the image layers built before it. The Makefile has been updated to add a `build-minimal` target. The main ocm-container image, build pipeline, and the rest of the Makefile will be unchanged by this PR. Signed-off-by: Chris Collins <[email protected]>
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, T0MASD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorders the Container file to add an ocm-contianer-minimal
build target consisting of the base backplane-tools install.
This includes a couple of other small reorder changes that should allow
for more caching during local builds for quicker and easier testing,
particularly of the backplane-tools install steps and the image layers
built before it.
The Makefile has been updated to add a
build-minimal
target.The main ocm-container image, build pipeline, and the rest of the
Makefile will be unchanged by this PR.
Signed-off-by: Chris Collins [email protected]