Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-ISSUE] Test case for lowercase Jira ticket names #1964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bradmwilliams
Copy link
Contributor

We had a scenario come up where the release-controller did not take the expected action, on a JIRA ticket, when it was included in a nightly build. After some digging, it turned out that the commit message contained the ticket id in lowercase.

Jira ticket: https://issues.redhat.com/browse/OCPBUGS-48504
PR: openshift/oc-mirror#1008
First Accepted nightly, post merge: https://amd64.ocp.releases.ci.openshift.org/releasestream/4.18.0-0.nightly/release/4.18.0-0.nightly-2025-01-21-015441

Corresponding Release-controller changelog:
image

This PR adds a test case that illustrates the expected behavior if/when a commit message comes in that doesn't match the expected regex here

The result is that there is no associated reference to a valid Bug.

@ardaguclu
Copy link
Member

/lgtm
/hold
feel free cancel hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, bradmwilliams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@bradmwilliams
Copy link
Contributor Author

/unhold
Nothing critical and fully expect all tests to pass

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@bradmwilliams
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@bradmwilliams: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 96677c6 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants