Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CVEs #1960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dhaiducek
Copy link

@dhaiducek dhaiducek commented Jan 16, 2025

This is currently raising flags in our builds.

Related PRs (since Go updates don't cherry-pick cleanly):

Closes #1950

@openshift-ci openshift-ci bot requested review from ardaguclu and atiratree January 16, 2025 17:33
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhaiducek
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pastequo
Copy link

Hello @dhaiducek

Could you also address this one as well ? GHSA-v725-9546-7q7m
It's an indirect dependency

@giladravid16
Copy link

Hey @dhaiducek

Just to clarify on what @pastequo wrote above, we also need that extra CVE fix on the related PRs you opened (specifically on the 4.17 branch).
Can it be added to them as well?

@dhaiducek
Copy link
Author

@giladravid16 @pastequo I've added the go-git update to the other PRs, but I'm also not a maintainer. I'm in a similar situation where we have oc as a dependency and need the critical vulnerabilities addressed here for our builds to pass.

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@dhaiducek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial ac7e870 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vulnerability reported by scan tools like Aqua or Trivy
3 participants