Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: admin/upgrade/status/examples/README: Document *-alerts.json #1959

Conversation

wking
Copy link
Member

@wking wking commented Jan 14, 2025

Catching the docs up with 10c41f5 (#1740).

Also drop the enumeration that started when the file was created in 57e9844 (#1595). Folks who care how many inputs and outputs there currently are can count for themselves, and this content is easier to maintain without having to bump later entry numbers when inserting an earlier entry.

Catching the docs up with 10c41f5 (add alerts to update health in
oc adm upgrade status, 2024-04-25, openshift#1740).

Also drop the enumeration that started when the file was created in
57e9844 (`adm upgrade status`: add fixture test, 2023-11-09, openshift#1595).
Folks who care how many inputs and outputs there currently are can
count for themselves, and this content is easier to maintain without
having to bump later entry numbers when inserting an earlier entry.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link

@wking: This pull request explicitly references no jira issue.

In response to this:

Catching the docs up with 10c41f5 (#1740).

Also drop the enumeration that started when the file was created in 57e9844 (#1595). Folks who care how many inputs and outputs there currently are can count for themselves, and this content is easier to maintain without having to bump later entry numbers when inserting an earlier entry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@ingvagabund
Copy link
Member

/retest-required

@petr-muller
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller January 14, 2025 13:29
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petr-muller
Copy link
Member

/label acknowledge-critical-fixes-only

This is a docs-only change

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 14, 2025
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@wking
Copy link
Member Author

wking commented Jan 15, 2025

Doc-only change:

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

9 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

4 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 7de55e3 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e005223 and 2 for PR HEAD 7de55e3 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 56e146c into openshift:master Jan 25, 2025
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-tools
This PR has been included in build ose-tools-container-v4.19.0-202501250737.p0.g56e146c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli
This PR has been included in build openshift-enterprise-cli-container-v4.19.0-202501250938.p0.g56e146c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer
This PR has been included in build openshift-enterprise-deployer-container-v4.19.0-202501250938.p0.g56e146c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts
This PR has been included in build ose-cli-artifacts-container-v4.19.0-202501250938.p0.g56e146c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants