-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: admin/upgrade/status/examples/README: Document *-alerts.json #1959
NO-ISSUE: admin/upgrade/status/examples/README: Document *-alerts.json #1959
Conversation
Catching the docs up with 10c41f5 (add alerts to update health in oc adm upgrade status, 2024-04-25, openshift#1740). Also drop the enumeration that started when the file was created in 57e9844 (`adm upgrade status`: add fixture test, 2023-11-09, openshift#1595). Folks who care how many inputs and outputs there currently are can count for themselves, and this content is easier to maintain without having to bump later entry numbers when inserting an earlier entry.
@wking: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/retest-required |
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/label acknowledge-critical-fixes-only This is a docs-only change |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
Doc-only change: /retest-required |
9 similar comments
4 similar comments
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
56e146c
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: ose-tools |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-cli |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-deployer |
[ART PR BUILD NOTIFIER] Distgit: ose-cli-artifacts |
Catching the docs up with 10c41f5 (#1740).
Also drop the enumeration that started when the file was created in 57e9844 (#1595). Folks who care how many inputs and outputs there currently are can count for themselves, and this content is easier to maintain without having to bump later entry numbers when inserting an earlier entry.