Skip to content

NO-JIRA: Fix for Improve DPA additionalPrinterColumns #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Mar 19, 2025

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes along with rebase.

Thank you to @hariprakash619 for contribution!

Fixes #1659

How to test the changes made

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025

@kaovilai: This pull request references OADP-1659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025

@kaovilai: This pull request references OADP-1659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes.

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025

@kaovilai: This pull request references OADP-1659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes.

Thank you to @hariprakash619 for contribution!

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025

@kaovilai: This pull request references OADP-1659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes along with rebase.

Thank you to @hariprakash619 for contribution!

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member Author

kaovilai commented Mar 19, 2025

Actually this PR has nothing to do with jira ticket OADP-1659

@kaovilai kaovilai changed the title OADP-1659: Fix for Improve DPA additionalPrinterColumns Fix for Improve DPA additionalPrinterColumns Mar 19, 2025
@openshift-ci-robot
Copy link

@kaovilai: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes along with rebase.

Thank you to @hariprakash619 for contribution!

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
Copy link

openshift-ci bot commented Mar 19, 2025

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rayfordj
Copy link
Contributor

/retitle NO-JIRA: Fix for Improve DPA additionalPrinterColumns
/lgtm

@openshift-ci openshift-ci bot changed the title Fix for Improve DPA additionalPrinterColumns NO-JIRA: Fix for Improve DPA additionalPrinterColumns Mar 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link

@kaovilai: This pull request explicitly references no jira issue.

In response to this:

Why the changes were made

From #1668 as of hariprakash619@5d4f664 with make manifests generate bundle changes along with rebase.

Thank you to @hariprakash619 for contribution!

Fixes #1659

How to test the changes made

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ed682cc into openshift:master Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DPA additionalPrinterColumns
5 participants