Bug 1907333: daemon: Revert code to remove rollback

[cgwalters]

See https://bugzilla.redhat.com/1907333

Doing this when the MCD lands on a node the first time means
we compete for I/O with lots of other containers, and on
slow systems that can cause a timeout. Then a further
problem is that we were fatally erroring out in the MCD
rather than retrying.

But we don't have control loop in the MCD today outside of
trying to apply an update; let's defer this until we add one.

[openshift-ci-robot]

@cgwalters: This pull request references Bugzilla bug 1907333, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907333: daemon: Revert code to remove rollback

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuqi-zhang]

Should probably remove

machine-config-operator/pkg/daemon/update.go

Line 700 in 4a005cb

func (dn *Daemon) removeRollback() error {

as well, since there is no other reference to it.

Otherwise I'm 👍

[cgwalters]

Eh, I would have kept it since we might use it in the future, but OK I removed it.

That said I think what we really want actually is coreos/rpm-ostree#2389

[mandre]

/test e2e-openstack
Moment of truth...

[mandre]

There is progress, at least now it's deploying the cluster 👍

[sinnykumari]

/lgtm
/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sinnykumari]

/test e2e-aws

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@cgwalters: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2302

Bugzilla bug 1907333 has been moved to the MODIFIED state.

In response to this:

Bug 1907333: daemon: Revert code to remove rollback

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

But we don't have control loop in the MCD today outside of trying to apply an update; let's defer this until we add one.

...time passes...we do now! Added in #3070

So I think we could safely do a PR that re-reverts this (i.e. readds it) to fix https://bugzilla.redhat.com/show_bug.cgi?id=2104619