Drop deprecated controllers, update e2e to machine.openshift.io #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Closed
enxebre
force-pushed
the
drop-deprecated-controllers
branch
4 times, most recently
from
b1444db to
aefc6bb
Compare
frobware
requested changes
Feb 7, 2019
|
/lgtm |
frobware
approved these changes
Feb 7, 2019
enxebre
force-pushed
the
drop-deprecated-controllers
branch
from
aefc6bb to
a656ead
Compare
enxebre
force-pushed
the
drop-deprecated-controllers
branch
from
a656ead to
46b8bec
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
enxebre
force-pushed
the
drop-deprecated-controllers
branch
from
46b8bec to
80be1c1
Compare
enxebre
force-pushed
the
drop-deprecated-controllers
branch
from
80be1c1 to
1e54d5e
Compare
|
e2e-aws-operator needs openshift/cluster-autoscaler-operator#35 and openshift/kubernetes-autoscaler#29 |
|
/test e2e-aws-operator |
enxebre
changed the title
|
/lgtm |
ingvagabund
pushed a commit
to ingvagabund/machine-api-operator
that referenced
this pull request
Jul 11, 2019
…ster-api Revendor github.com/openshift/cluster-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop deprecated controllers
Update e2e-operator test to run against machine.openshift.io
Leave cluster.k8s.io CRDs for now since they are still used by openstack