Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]add proxy system properties as expected by kubernetes-client #1254

Closed
wants to merge 1 commit into from

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Apr 15, 2021

system properties are expected in this format , keeping the old ones because it is the standard way for java application to receive the proxy settigns, so some other plugins may use the standard way

https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Config.java#L119

Putting this in WIP because it needs fabric8io/kubernetes-client#3000
I will then bump the plugin in the current PR

@openshift-ci-robot
Copy link
Contributor

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

add proxy system properties as expected by kubernetes-client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@jkhelil jkhelil changed the title add proxy system properties as expected by kubernetes-client WIP add proxy system properties as expected by kubernetes-client Apr 15, 2021
@openshift-ci-robot
Copy link
Contributor

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP add proxy system properties as expected by kubernetes-client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2021
@openshift-ci-robot
Copy link
Contributor

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP add proxy system properties as expected by kubernetes-client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Contributor

/retest

@jkhelil jkhelil changed the title WIP add proxy system properties as expected by kubernetes-client add proxy system properties as expected by kubernetes-client Apr 23, 2021
@openshift-ci-robot
Copy link
Contributor

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

add proxy system properties as expected by kubernetes-client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2021
@jkhelil jkhelil changed the title add proxy system properties as expected by kubernetes-client [WIP]add proxy system properties as expected by kubernetes-client Apr 23, 2021
@openshift-ci-robot
Copy link
Contributor

@jkhelil: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[WIP]add proxy system properties as expected by kubernetes-client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2021
@jkhelil jkhelil closed this Apr 23, 2021
@jkhelil
Copy link
Contributor Author

jkhelil commented Apr 23, 2021

Not relevant replaced by #1263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants