Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Embed rhcos*.json as /bootimage/rhcos*.json in container image #4102

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

This is intended as a short term tweak on the (long) road
to openshift/enhancements#201

See specifically this subthread:
openshift/enhancements#201 (comment)
And openshift/enhancements#201 (comment)

TL;DR we want oc to be the frontend to this data, via something like
oc adm release info --bootimage-json or so, and not openshift-install.

We want to move towards having the data as part of the release image.
But the installer will have RHCOS pinned for the near future because
of the bootstrap node - we need an RHCOS for that too.

And it's going to be very problematic to have "two sources of truth"
for RHCOS even temporarily.

This small change puts the RHCOS json inside the installer container
image which is already part of the release payload and built from
this repository; then we can patch oc to have oc adm bootimages --json
which would do the equivalent of:
oc image extract /bootimage:. $(oc adm release info --image-for=installer))

This is intended as a short term tweak on the (long) road
to openshift/enhancements#201

See specifically this subthread:
openshift/enhancements#201 (comment)
And openshift/enhancements#201 (comment)

TL;DR we want `oc` to be the frontend to this data, via something like
`oc adm release info --bootimage-json` or so, and not `openshift-install`.

We want to move towards having the data as part of the release image.
But the installer will have RHCOS pinned for the near future because
of the bootstrap node - we need an RHCOS for that too.

And it's going to be very problematic to have "two sources of truth"
for RHCOS even temporarily.

This small change puts the RHCOS json inside the `installer` container
image which is already part of the release payload and built from
this repository; then we can patch `oc` to have `oc adm bootimages --json`
which would do the equivalent of:
`oc image extract /bootimage:. $(oc adm release info --image-for=installer))`
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 09d3968 link /test e2e-ovirt
ci/prow/e2e-crc 09d3968 link /test e2e-crc
ci/prow/e2e-openstack 09d3968 link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member Author

This can probably wait for 4.7, just trying to make a bit of forward progress on this.

@cgwalters
Copy link
Member Author

I just noticed that the UPI container already does this:
COPY --from=builder /go/src/github.com/openshift/installer/data/data/rhcos.json /var/lib/openshift-install/rhcos.json

@wking
Copy link
Member

wking commented Aug 27, 2020

UPI image should be CI-only, not part of official releases. I hope :p

@cgwalters cgwalters changed the title Embed rhcos*.json as /bootimage/rhcos*.json in container image WIP: Embed rhcos*.json as /bootimage/rhcos*.json in container image Aug 28, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2020
@abhinavdahiya
Copy link
Contributor

@cgwalters what's our plan, if any, to move ahead with 201 for 4.7 ?

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants