-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Embed rhcos*.json as /bootimage/rhcos*.json in container image #4102
Conversation
This is intended as a short term tweak on the (long) road to openshift/enhancements#201 See specifically this subthread: openshift/enhancements#201 (comment) And openshift/enhancements#201 (comment) TL;DR we want `oc` to be the frontend to this data, via something like `oc adm release info --bootimage-json` or so, and not `openshift-install`. We want to move towards having the data as part of the release image. But the installer will have RHCOS pinned for the near future because of the bootstrap node - we need an RHCOS for that too. And it's going to be very problematic to have "two sources of truth" for RHCOS even temporarily. This small change puts the RHCOS json inside the `installer` container image which is already part of the release payload and built from this repository; then we can patch `oc` to have `oc adm bootimages --json` which would do the equivalent of: `oc image extract /bootimage:. $(oc adm release info --image-for=installer))`
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This can probably wait for 4.7, just trying to make a bit of forward progress on this. |
I just noticed that the UPI container already does this: |
UPI image should be CI-only, not part of official releases. I hope :p |
@cgwalters what's our plan, if any, to move ahead with 201 for 4.7 ? |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is intended as a short term tweak on the (long) road
to openshift/enhancements#201
See specifically this subthread:
openshift/enhancements#201 (comment)
And openshift/enhancements#201 (comment)
TL;DR we want
oc
to be the frontend to this data, via something likeoc adm release info --bootimage-json
or so, and notopenshift-install
.We want to move towards having the data as part of the release image.
But the installer will have RHCOS pinned for the near future because
of the bootstrap node - we need an RHCOS for that too.
And it's going to be very problematic to have "two sources of truth"
for RHCOS even temporarily.
This small change puts the RHCOS json inside the
installer
containerimage which is already part of the release payload and built from
this repository; then we can patch
oc
to haveoc adm bootimages --json
which would do the equivalent of:
oc image extract /bootimage:. $(oc adm release info --image-for=installer))