modules/libvirt/bootstrap: Pull libvirt bootstrap setup into a module #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to move into the existing infra step. The module source syntax used in the README is documented in [1,2,3], and means "the modules/libvirt/bootstrap subdirectory of the github.com/openshift/installer repository cloned over HTTPS". [1]: https://www.terraform.io/docs/configuration/modules.html#source [2]: https://www.terraform.io/docs/modules/sources.html#github [3]: https://www.terraform.io/docs/modules/sources.html#modules-in-package-sub-directories
openshift-ci-robot
added
size/L
wking
force-pushed
the
libvirt-bootstrap-module
branch
from
a51d628 to
67af0ec
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Now that openshift/release#1449 has landed. |
|
/retest |
|
/hold In local testing I'm having some trouble getting the workers up: It might be just an image-pulling-bandwidth issue; I'll try again with a longer timeout. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel Giving it more time did the trick. |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to move into the existing infra step (like #217, but for libvirt).
The module source syntax used in the README is documented here, here, and here, and means "the modules/libvirt/bootstrap subdirectory of the github.com/openshift/installer repository cloned over HTTPS".