Change awsproviderconfig.k8s.io/v1alpha1 API version to awsproviderconfig.openshift.io/v1beta1 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig.openshift.io/v1beta1 As part of migrating from upstream k8s.io group (cluster API) into openshift.io group (machine API), we are changing all upstream API versions into our openshift machine API implementation. This change allows us to interate more quickly over machine API implementation. PR changing the API version in aws actuator: openshift/cluster-api-provider-aws#152
openshift-ci-robot
added
the
size/XS
|
The logs show all three worker node are in Ready state and the machine controller was able to provision ec2 instances. |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
This seems like it was too narrow. What about these? $ git log -1 --oneline
3804a86 Merge pull request #1223 from ingvagabund/k8s-to-openshift
$ git grep 'sigs.k8s.io/cluster-api-provider-aws.*v1'
Gopkg.lock: "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsproviderconfig/v1alpha1",
pkg/asset/cluster/tfvars.go: awsprovider "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsproviderconfig/v1alpha1"
pkg/asset/machines/aws/machines.go: awsprovider "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsproviderconfig/v1alpha1"
pkg/tfvars/aws/aws.go: "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsproviderconfig/v1alpha1"Was there a reason you didn't bump those? |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 11, 2019
And shift the AWS provider's commit to land after they fixed registration [1] and also after their pivot to v1beta1 [2] (because 3a125a6, Change awsproviderconfig.k8s.io/v1alpha1 API version to awsproviderconfig.openshift.io/v1beta1, 2019-02-11, openshift#1223 already started us along that pivot). Generated (after the Gopkg.toml bump) with: $ dep ensure using: $ dep version dep: version : v0.5.0-31-g73b3afe build date : 2019-02-08 git hash : 73b3afe go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false [1]: openshift/cluster-api-provider-aws#149 [2]: openshift/cluster-api-provider-aws#152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of migrating from upstream k8s.io group (cluster API) into openshift.io group (machine API),
we are changing all upstream API versions into our openshift machine API implementation.
This change allows us to interate more quickly over machine API implementation.
PR changing the API version in aws actuator: openshift/cluster-api-provider-aws#152