Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating openshift-enterprise-base builder & base images to be consistent with ART #44

Conversation

jupierce
Copy link
Contributor

@jupierce jupierce commented Oct 7, 2020

Updating openshift-enterprise-base builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/f66c03011773dc3755ad874fc691be612914d65f/images/openshift-enterprise-base.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

This was referenced Oct 7, 2020
This was referenced Oct 7, 2020
@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

Should master move to track another tag and make changing to release specific tags part of the branching process?

@hongkailiu
Copy link
Member

/refresh

@jupierce
Copy link
Contributor Author

jupierce commented Oct 7, 2020

/retest

1 similar comment
@jupierce
Copy link
Contributor Author

jupierce commented Oct 7, 2020

/retest

@jupierce jupierce force-pushed the art-consistency-openshift-4.7-openshift-enterprise-base branch from d32b8ea to 011536c Compare October 7, 2020 19:54
@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@jupierce
Copy link
Contributor Author

jupierce commented Oct 7, 2020

@sdodson since this PR is clearly a bottleneck, I've tweaked the ART metadata. The rhel7/8 base images don't presently vary by release, so I've removed the '4.x' in the FROM. The change should prevent this image from being hit with every branch cut.

@openshift-merge-robot openshift-merge-robot merged commit ec6a8a8 into openshift:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants