Fix transient mounts in Docker 1.12 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
mount_secret
branch
from
629954b to
ef006a3
Compare
|
@jawnsy can you give this a try on 1.12 and see it works for you? |
smarterclayton
force-pushed
the
mount_secret
branch
from
ef006a3 to
6dfd613
Compare
|
Good news - there appears to be a race in docker 1.12 where volumes aren't initialized prior to startup. That's what blocks this. |
Use a temporary container to receive the copy instead of using host mounts.
smarterclayton
force-pushed
the
mount_secret
branch
from
6dfd613 to
43a7086
Compare
Use the same flag constructs. Also refactor the code for more flexibility in the future and easier consumption.
jawnsy
reviewed
Oct 26, 2016
|
|
||
| ``` | ||
| $ imagebuilder path_to_directory output_image_name | ||
| $ imagebuilder [-t TAG] DIRECTORY |
There was a problem hiding this comment.
Isn't this a breaking change? What's our compatibility statement with respect to use of imagebuilder in scripts?
There was a problem hiding this comment.
Yes, and none (yet).
|
Merging to unbreak docker 1.12 for everything except transient mounts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a temporary container instead of hostconfig on start. Add a test case.
Fixes #6