Add ThroughTarget function to builder #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TomSweeneyRedHat <[email protected]> docker build has a --target option that builds the stages from stage 0 through and including the target specified. The current ByTarget() function returns only the specified stage. The new ThroughTarget function is heavily based on ByTarget and will now return the targeted stage plus the prior stages emulating the docker build --target functionality. Added tests for both ByTarget and ThroughTarget Signed-off-by: TomSweeneyRedHat <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
Needed for containers/buildah#1321. @rhatdan @umohnani8 @nalind @vrothberg PTAL |
|
LGTM 👍 |
|
LGTM |
|
LGTM |
|
/retest |
|
@nalind can you PTAL and merge if it's hip? I've a WIP Buildah PR waiting this one getting merged. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat [email protected]
docker build has a --target option that builds the stages from
stage 0 through and including the target specified. The current
ByTarget() function returns only the specified stage. The new
ThroughTarget function is heavily based on ByTarget and will now
return the targeted stage plus the prior stages emulating the
docker build --target functionality.
Added tests for both ByTarget and ThroughTarget
Signed-off-by: TomSweeneyRedHat [email protected]