Skip region check for CCS ProjectClaims #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
NautiluX
force-pushed
the
ccs-skip-region
branch
from
ff80e90 to
945bad3
Compare
* In CCS, the user is responsible for ensuring enough quota in the provided project, hence skip region check * The region check resulted in a error loop for unsupported regions, as the reconcile returned an error * Add `ConditionInvalid` for failed condition checks * Add missing `return` statement * Fix some warnings for missing checks in return codes * Refactor util.OperationResult functions for easier asserting on results * `go mod tidy`, `go mod vendor`
NautiluX
force-pushed
the
ccs-skip-region
branch
from
945bad3 to
068f181
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NautiluX, rafael-azevedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bugfix && feature && refactor
What this PR does / why we need it:
ConditionInvalidfor failed condition checksreturnstatementgo mod tidy,go mod vendorWhich issue(s) this PR fixes(can be a reference to existing issue or jira/bz):
Fixes OSD-5710
Pre-checks:
make coveragecommand to generate new calculated coverage