Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1802: Update the operand image to 0.14.2 #228

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Sep 3, 2024

This PR updates the operand image to include the latest changes from the upstream's 0.14.2 version, as introduced in the rebase PR.

External-dns repository from quay.io: link (latest tag).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2024

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR updates the operand image to include the latest changes from the upstream's 0.14.2 version, as introduced in the rebase PR.

External-dns repository from quay.io: link(latest tag).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2024

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR updates the operand image to include the latest changes from the upstream's 0.14.2 version, as introduced in the rebase PR.

External-dns repository from quay.io: link (latest tag).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

/retest

Cluster provisioning problems on Azure.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Sep 3, 2024

Azure failures are related to a reached limit for CI DNS zone:

message": "You have reached or exceeded the maximum number of record resources in zone 'ci.azure.devcluster.openshift.com'. You have 10000 record resources of 10000 allowed."

@alebedev87
Copy link
Contributor Author

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/assign @gcs278

@alebedev87
Copy link
Contributor Author

/test e2e-azure-infoblox-operator

Cluster installation failure.

Copy link
Contributor

@gcs278 gcs278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit pick, otherwise LGTM

config/manager/manager.yaml Outdated Show resolved Hide resolved
@gcs278
Copy link
Contributor

gcs278 commented Sep 5, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@alebedev87
Copy link
Contributor Author

Azure installations are flaky lately.

/retest

@alebedev87
Copy link
Contributor Author

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@gcs278
Copy link
Contributor

gcs278 commented Sep 9, 2024

There's some slack activity on the DNS records filling up which is causing azure installs to fail. It may work now, if it hasn't filled up again.
/test e2e-azure-infoblox-operator

@melvinjoseph86
Copy link

Tested the pr using cluster bot, basic functionality is working. Hence approving from QE side.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2024

@alebedev87: This pull request references NE-1802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR updates the operand image to include the latest changes from the upstream's 0.14.2 version, as introduced in the rebase PR.

External-dns repository from quay.io: link (latest tag).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@melvinjoseph86
Copy link

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/label px-apporved

No TE needed for this feature, release notes are enough.

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@alebedev87: The label(s) `/label px-apporved

cannot be applied. These labels are supported:acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

/label px-apporved

No TE needed for this feature, release notes are enough.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alebedev87
Copy link
Contributor Author

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 11, 2024
@jmanthei
Copy link

jmanthei commented Sep 11, 2024

/label docs-approved

In the release notes we will mention that we now use 0.14.2 version of the upstream project.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 11, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 178cf49 and 2 for PR HEAD 44aaacd in total

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b2a62fe into openshift:main Sep 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants