Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Move to 4.19 on go1.23 #333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

joepvd
Copy link

@joepvd joepvd commented Nov 28, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from jsafrane and mandre November 28, 2024 19:31
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joepvd
Once this PR has been reviewed and has the lgtm label, please assign emilienm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd joepvd changed the title Move to 4.19 on go1.23 NO-JIRA: Move to 4.19 on go1.23 Nov 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2024
@openshift-ci-robot
Copy link

@joepvd: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joepvd
Copy link
Author

joepvd commented Nov 29, 2024

/retest

1 similar comment
@joepvd
Copy link
Author

joepvd commented Nov 30, 2024

/retest

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, at least for the OpenStack images, just wondering why this isn't an automated PR... Shouldn't the bot have submitted the PR?

@gnufied
Copy link
Member

gnufied commented Dec 10, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@joepvd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-e2e-openstack-csi-manila 9b41ebc link true /test hypershift-e2e-openstack-csi-manila
ci/prow/okd-scos-e2e-aws-ovn 9b41ebc link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack-csi 9b41ebc link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

@joepvd all ART PRs are merged, can we close this PR?
(And how it did not conflict?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants