Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go v1.19 #45

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Update to go v1.19 #45

merged 2 commits into from
Nov 2, 2022

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Nov 1, 2022 •
edited
Loading

Also, carry kubernetes-csi#379.

CC @openshift/storage

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana November 1, 2022 17:12
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@bertinatto bertinatto changed the title UPSTREAM: 379: Fix gofmt for go 1.19 Update to go v1.19 Nov 1, 2022
@jsafrane
Copy link

jsafrane commented Nov 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@jsafrane jsafrane added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Nov 1, 2022
@jsafrane
Copy link

jsafrane commented Nov 1, 2022

Added labels manually as openshift-bot did in #44

@bertinatto bertinatto mentioned this pull request Nov 1, 2022
Closed
@jsafrane
Copy link

jsafrane commented Nov 2, 2022

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2022

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0eedc75 into openshift:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

@jhou1 jhou1

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bertinatto @jsafrane @jhou1 @chao007 @openshift-merge-robot @duanwei33 @ropatil010 @Phaow