Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2263: UPSTREAM: 931: test: correct driver capabilities #22

Closed
wants to merge 1 commit into from

Conversation

Phaow
Copy link

@Phaow Phaow commented Feb 24, 2025

  • Correct the test capabilities to keep consistent with what actually supports.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025

@Phaow: This pull request references STOR-2263 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Correct the test capabilities to keep consistent with what actually supports.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and dobsonj February 24, 2025 01:23
@Phaow Phaow changed the title STOR-2263: UPSTREAM: 931: test: correct external-e2e driver capabilities STOR-2263: UPSTREAM: 931: test: correct driver capabilities Feb 24, 2025
Copy link

openshift-ci bot commented Feb 24, 2025

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5894b3d link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link
Author

Phaow commented Feb 24, 2025

Hi @gnufied @mpatlasov , could you help take a look when you get a chance? Thank you!

@Phaow
Copy link
Author

Phaow commented Feb 24, 2025

/assign @gnufied @mpatlasov

@dfajmon
Copy link

dfajmon commented Feb 26, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon, Phaow
Once this PR has been reviewed and has the lgtm label, please ask for approval from gnufied. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link

Hold on, I think this file is not used anywhere in OCP. https://github.com/openshift/csi-operator/tree/main/test/e2e/samba is the right file.

@Phaow
Copy link
Author

Phaow commented Feb 27, 2025

@jsafrane Correct, though I've already correct it in upstream by kubernetes-csi#931 , we could wait for the next rebase make it correct, actually it is useless in our CI e2e tests. Thanks for looking into this!

@Phaow
Copy link
Author

Phaow commented Feb 27, 2025

/close

@openshift-ci openshift-ci bot closed this Feb 27, 2025
Copy link

openshift-ci bot commented Feb 27, 2025

@Phaow: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants