-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-2263: UPSTREAM: 931: test: correct driver capabilities #22
Conversation
Phaow
commented
Feb 24, 2025
- Correct the test capabilities to keep consistent with what actually supports.
@Phaow: This pull request references STOR-2263 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Phaow: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi @gnufied @mpatlasov , could you help take a look when you get a chance? Thank you! |
/assign @gnufied @mpatlasov |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dfajmon, Phaow The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hold on, I think this file is not used anywhere in OCP. https://github.com/openshift/csi-operator/tree/main/test/e2e/samba is the right file. |
@jsafrane Correct, though I've already correct it in upstream by kubernetes-csi#931 , we could wait for the next rebase make it correct, actually it is useless in our CI e2e tests. Thanks for looking into this! |
/close |
@Phaow: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |