Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip]OTA-1427: USC: Maintain status insights for Nodes #1136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[wip]OTA-1427: USC: Maintain status insights for Nodes #1136

wants to merge 1 commit into from
+14,686 −0

Conversation

hongkailiu
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1427 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu hongkailiu changed the title OTA-1427: USC: Maintain status insights for Nodes [wip]OTA-1427: USC: Maintain status insights for Nodes Jan 21, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@openshift-ci openshift-ci bot requested review from DavidHurta and wking January 21, 2025 22:37
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu hongkailiu force-pushed the OTA-1427 branch 3 times, most recently from c50bd1d to 74e95bf Compare January 22, 2025 17:00
hongkailiu
hongkailiu commented Jan 22, 2025
View reviewed changes
pkg/updatestatus/mco/controller_common_constants.go
@@ -0,0 +1,83 @@
// Taken from: https://github.com/openshift/machine-config-operator/blob/11d5151a784c7d4be5255ea41acfbf5092eda592/pkg/controller/common/constants.go
// TODO: Replace this file with the original MCO code when transitioning to server-side
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to import the code from the mco repo?
We made some changes on some files in this folder but this file seems unchanged.

@hongkailiu hongkailiu force-pushed the OTA-1427 branch 2 times, most recently from 33e7f94 to 645da03 Compare January 22, 2025 23:23
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 145d1de link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn-upgrade-into-change 145d1de link true /test e2e-agnostic-ovn-upgrade-into-change
ci/prow/e2e-hypershift 145d1de link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@wking wking Awaiting requested review from wking

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongkailiu @openshift-ci-robot