go.mod,go.sum,vendor,jsonnet: Bump and lock dependencies #624

paulfantom · 2020-01-23T09:57:38Z

Bump go deps:

k8s 1.17.1 version
prometheus-operator 0.35.0

Lock jsonnet deps

/cc @lilic @s-urbaniak

s-urbaniak · 2020-01-23T09:59:24Z

/lgtm

openshift-bot · 2020-01-23T10:22:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

s-urbaniak · 2020-01-23T10:39:42Z

@paulfantom for jsonnet, i think this is missing a make generate-in-docker, as we have little changes at least in kubernetes-mixin

paulfantom · 2020-01-23T10:57:00Z

This was "funny", I did make clean && make generate-in-docker and nothing changed. It appears jb is preferring transitive dependency over an explicit one.
We locked kubernetes-mixin to a7ee9d1abe1b1a3670a02ede1135cadb660b9d0c in coreos/kube-prometheus and jb used that one instead of one defined in jsonnet/jsonnetfile.json. After manually changing version in jsonnet/jsonnetfile.lock.json and regenerating it picked up changes from kubernetes-mixins.

/shrug

s-urbaniak · 2020-01-23T11:07:18Z

/lgtm

paulfantom · 2020-01-23T12:50:43Z

/retest

lilic · 2020-01-23T13:33:57Z

assets/thanos-querier/deployment.yaml

+                  values:
+                  - thanos-querier
+              namespaces:
+              - monitoring


This is the problem, we have to exclude this change.

We have issue to properly configure this in the next release.

Should we use previous kube-thanos release or should we cut a release branch before thanos-io/kube-thanos#84 and use it here? Personally I am in favor of the latter approach.

/cc @s-urbaniak

hmm, didn't we want to mask this out in jsonnet in CMO?

i will mask this specific change out here in this PR, i was under the impression we wanted to do this initially @lilic 🤔

ok, masked this out in e6ba2bf

no, because in the previous PR I didn't need that dep, it did not come from kube-prometheus that I was bumping.

paulfantom · 2020-01-23T16:10:55Z

/retest

brancz · 2020-01-23T16:11:11Z

/lgtm

openshift-bot · 2020-01-25T00:06:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T01:50:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T02:06:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T02:56:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T03:34:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T03:47:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T04:52:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T05:05:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T05:18:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T05:31:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T06:10:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T06:23:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T06:36:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T07:15:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T07:28:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T07:41:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T08:46:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T08:59:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T09:12:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T09:26:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T10:04:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T10:18:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T11:09:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T11:22:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T11:49:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T12:01:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from lilic and s-urbaniak January 23, 2020 09:57

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2020

paulfantom mentioned this pull request Jan 23, 2020

go.mod,go.sum,vendor: Bump to k8s 1.17.1 version #621

Closed

openshift-ci-robot assigned s-urbaniak Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

paulfantom force-pushed the deps branch from 8336f4c to bf98df7 Compare January 23, 2020 10:34

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

paulfantom changed the title ~~go.mod,go.sum,vendor: Bump dependencies~~ go.mod,go.sum,vendor,jsonnet: Bump and lock dependencies Jan 23, 2020

paulfantom force-pushed the deps branch from 563aaaa to f0bfa2f Compare January 23, 2020 10:54

openshift-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

paulfantom force-pushed the deps branch from f0bfa2f to 9e43416 Compare January 23, 2020 11:36

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 23, 2020

paulfantom force-pushed the deps branch from 9e43416 to 6f2ff27 Compare January 23, 2020 11:52

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020

paulfantom force-pushed the deps branch from 6f2ff27 to 51385c7 Compare January 23, 2020 12:38

lilic reviewed Jan 23, 2020

View reviewed changes

paulfantom force-pushed the deps branch from 33e3644 to 76369f1 Compare January 23, 2020 15:00

openshift-ci-robot assigned brancz Jan 23, 2020

openshift-merge-robot merged commit f549641 into openshift:master Jan 25, 2020

paulfantom deleted the deps branch January 25, 2020 15:37

pgier mentioned this pull request May 18, 2020

Bug 1833427: retain pvc metadata openshift/prometheus-operator#70

Merged

lilic mentioned this pull request May 19, 2020

Release 0.4 prom oper v0.35.1 prometheus-operator/kube-prometheus#536

Merged

go.mod,go.sum,vendor,jsonnet: Bump and lock dependencies #624

go.mod,go.sum,vendor,jsonnet: Bump and lock dependencies #624

Conversation

paulfantom commented Jan 23, 2020 • edited Loading

s-urbaniak commented Jan 23, 2020

openshift-bot commented Jan 23, 2020

s-urbaniak commented Jan 23, 2020

paulfantom commented Jan 23, 2020

s-urbaniak commented Jan 23, 2020

paulfantom commented Jan 23, 2020

lilic Jan 23, 2020

Choose a reason for hiding this comment

lilic Jan 23, 2020

Choose a reason for hiding this comment

paulfantom Jan 23, 2020 • edited Loading

Choose a reason for hiding this comment

s-urbaniak Jan 23, 2020

Choose a reason for hiding this comment

s-urbaniak Jan 23, 2020

Choose a reason for hiding this comment

s-urbaniak Jan 23, 2020

Choose a reason for hiding this comment

lilic Jan 23, 2020

Choose a reason for hiding this comment

paulfantom commented Jan 23, 2020

brancz commented Jan 23, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

openshift-bot commented Jan 25, 2020

paulfantom commented Jan 23, 2020 •

edited

Loading

paulfantom Jan 23, 2020 •

edited

Loading