Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-8366: manifests: create target namespace earlier #896

Closed
wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Mar 6, 2023

In order to speed up initial install target namespace definitions need to be included in the payload, as these need to have SCCs assigned and its benefitial to do this earlier on startup

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 6, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-8366, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In order to speed up initial install target namespace definitions need to be included in the payload, as these need to have SCCs assigned and its benefitial to do this earlier on startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jiajliu, knobunc and rfredette March 6, 2023 10:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miheer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the create-namespace-earlier branch from 5d9de99 to 5bebe3b Compare March 6, 2023 10:34
In order to speed up initial install target namespace definitions need
to be included in the payload, as these need to have SCCs assigned and
its benefitial to do this earlier on startup
@vrutkovs vrutkovs force-pushed the create-namespace-earlier branch from 5bebe3b to 7a0a2ca Compare March 6, 2023 10:51
@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 6, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2023

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 7a0a2ca link true /test e2e-azure-operator
ci/prow/e2e-aws-operator 7a0a2ca link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 7, 2023

/hold

This is a very hacky way to speed up cluster install. It would be best to improve scc controller / installation proceedure

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@vrutkovs
Copy link
Member Author

vrutkovs commented Mar 7, 2023

/hold

This is a very hacky way to speed up cluster install. It would be best to improve scc controller / installation procedure

@alebedev87
Copy link
Contributor

alebedev87 commented Mar 13, 2023

This PR would also help to reduce the cluster wide permissions by moving some of them to the operand namespaces.

@candita
Copy link
Contributor

candita commented Mar 29, 2023

/close

Per @deads2k: please don't merge. The CVO manages the operator. The operator manages to the operand.

@openshift-ci openshift-ci bot closed this Mar 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

@candita: Closed this PR.

In response to this:

/close

Per @deads2k: please don't merge. The CVO manages the operator. The operator manages to the operand.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-8366. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

In order to speed up initial install target namespace definitions need to be included in the payload, as these need to have SCCs assigned and its benefitial to do this earlier on startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants