CCO-320: Add support for Azure workload identity tokens #274
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dlom: This pull request references CCO-320 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@dlom: This pull request references CCO-320 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like the upstream PR is being worked on actively, is it possible to wait/help on that issue so that it's merged and then we can pick it down and drop it on the next rebase? CC @RadekManak there's no git history check on this repository, could you look at adding it? |
|
@dlom This didn't get picked up in the rebase, can you update the PR and use the |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Ashutosh Kumar <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
dlom
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@dlom: This pull request references CCO-320 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoelSpeed did I do it right? |
|
@elmiko does this look right? |
|
@dlom: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
when the carry patch openshift/cluster-api-provider-azure#274 was merged, `make assets` wasn't rerun on the cluster-capi-operator. To fix this we need to rerun asset generation and check in the changes showing up.
xref: CCO-320
Base commit: 5f39919 (taken from upstream kubernetes-sigs#3583)