-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cnf ran: ztp hub templating and node delete migration #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32fd53b
to
29d067f
Compare
Updated to turn the hub templating tests into positive tests and restrict them to TALM >=4.16 |
29d067f
to
2c21521
Compare
klaskosk
commented
Jul 11, 2024
yliu127
reviewed
Jul 11, 2024
sebrandon1
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the master/control-plane stuff.
2c21521
to
d742fac
Compare
yliu127
reviewed
Jul 11, 2024
d742fac
to
2da3890
Compare
yliu127
reviewed
Jul 12, 2024
2da3890
to
22ff11a
Compare
22ff11a
to
4c1ba43
Compare
/lgtm |
yliu127
approved these changes
Jul 12, 2024
sebrandon1
approved these changes
Jul 12, 2024
gkopels
pushed a commit
to gkopels/eco-gotests
that referenced
this pull request
Aug 18, 2024
gkopels
pushed a commit
to gkopels/eco-gotests
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.