Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf ran: ztp hub templating and node delete migration #84

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

klaskosk
Copy link
Collaborator

@klaskosk klaskosk commented Jul 9, 2024

No description provided.

@klaskosk klaskosk force-pushed the ztp-templating-delete branch 2 times, most recently from 32fd53b to 29d067f Compare July 11, 2024 17:35
@klaskosk
Copy link
Collaborator Author

Updated to turn the hub templating tests into positive tests and restrict them to TALM >=4.16

@klaskosk klaskosk force-pushed the ztp-templating-delete branch from 29d067f to 2c21521 Compare July 11, 2024 17:46
Copy link
Collaborator

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the master/control-plane stuff.

@klaskosk klaskosk force-pushed the ztp-templating-delete branch from 2c21521 to d742fac Compare July 11, 2024 19:26
@klaskosk klaskosk force-pushed the ztp-templating-delete branch from d742fac to 2da3890 Compare July 12, 2024 14:19
@klaskosk klaskosk force-pushed the ztp-templating-delete branch from 2da3890 to 22ff11a Compare July 12, 2024 17:38
@klaskosk klaskosk force-pushed the ztp-templating-delete branch from 22ff11a to 4c1ba43 Compare July 12, 2024 18:06
@yliu127
Copy link
Collaborator

yliu127 commented Jul 12, 2024

/lgtm

@klaskosk klaskosk merged commit ba904e7 into openshift-kni:main Jul 12, 2024
1 check passed
gkopels pushed a commit to gkopels/eco-gotests that referenced this pull request Aug 18, 2024
gkopels pushed a commit to gkopels/eco-gotests that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants