Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf ran: ztp test migration preliminaries #72

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

klaskosk
Copy link
Collaborator

This is the first PR for migrating the ZTP test suite and includes the ztp directory with the helper and tsparams packages. Additionally, some helpers and parameters are moved from the TALM suite into the ran directory so they may be shared with the ZTP tests.

@klaskosk
Copy link
Collaborator Author

Verified TALM suite passes after these changes

Copy link
Collaborator

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

@klaskosk
Copy link
Collaborator Author

@yliu127 @sebrandon1 Thanks for the comments, I've gone ahead and updated the PR and verified TALM still works again

@klaskosk klaskosk requested review from sebrandon1 and yliu127 June 28, 2024 20:32
Copy link
Collaborator

@mpmaruthu mpmaruthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments.

Copy link
Collaborator

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of comments.

This is the first PR for migrating the ZTP test suite and includes the ztp directory with the helper and tsparams packages. Additionally, some helpers and parameters are moved from the TALM suite into the ran directory so they may be shared with the ZTP tests.
@klaskosk klaskosk merged commit d90b659 into openshift-kni:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants