cnf ran: fix edge case that causes nil prBuilder #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain tests, the prBuilder is set then used again in AfterEach without being pulled again. When the test fails calling a function that sets prBuilder, this can lead to prBuilder being set to nil with no way to clean up after the tests. This PR addresses the issue by always pulling prBuilder in the AfterEach block.
yliu127
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain tests, the prBuilder is set then used again in AfterEach without being pulled again. When the test fails calling a function that sets prBuilder, this can lead to prBuilder being set to nil with no way to clean up after the tests. This PR addresses the issue by always pulling prBuilder in the AfterEach block.