Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnf ran: update skipped talm test case #210

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

klaskosk
Copy link
Collaborator

There is currently a test case in the TALM suite that is always skipped due to the inputs being wrong. This PR switches it to use a regex that will work in newer versions.

Copy link
Collaborator

@mpmaruthu mpmaruthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all : looks good to me but expect one minor test automation robustness concern needs to be addressed

There is currently a test case in the TALM suite that is always skipped due to the inputs being wrong. This PR switches it to use a regex that will work in newer versions.
@klaskosk klaskosk force-pushed the talm-precache-skipped branch from 0c755c2 to 19470e6 Compare September 19, 2024 13:14
@mpmaruthu
Copy link
Collaborator

Looks good to me.
/Peri M

@mpmaruthu mpmaruthu self-requested a review September 19, 2024 14:21
@mpmaruthu
Copy link
Collaborator

PR changes reviewed and approved.

/Peri M

@klaskosk klaskosk merged commit be66204 into openshift-kni:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants