Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: added all schemes to reporter package #194

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

klaskosk
Copy link
Collaborator

Updated the reporter package to add all of the schemes currently used in reports for this repo. Also removed the option to provide a scheme attacher to the reporter functions since it is now done by default.

Updated the reporter package to add all of the schemes currently used in reports for this repo. Also removed the option to provide a scheme attacher to the reporter functions since it is now done by default.
Copy link
Collaborator

@cdvultur cdvultur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@klaskosk klaskosk merged commit 96ca50e into openshift-kni:main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants