cnf ran: rename ztp directory to ran-ztp #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The naming convention for directories seems to be no special character in between two words. Also would be better to rename it to gitopsztp. |
Since the ztp directory is already used by assisted, using it in RAN CI requires using labels but this creates a lot of noise as it still runs tests and just skips the ones not selected by the label. By giving RAN ZTP tests the gitopsztp directory name they can still be run using ECO_TEST_FEATURES. Additionally, the test label is also changed to gitopsztp.
klaskosk
force-pushed
the
rename-ran-ztp
branch
from
f335182 to
29f3a4d
Compare
yliu127
approved these changes
Aug 6, 2024
josclark42
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ztp directory is already used by assisted, using it in RAN CI requires using labels but this creates a lot of noise as it still runs tests and just skips the ones not selected by the label. By giving RAN ZTP tests the ran-ztp directory name they can still be run using ECO_TEST_FEATURES.