Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for agentserviceconfig #437

Merged
merged 1 commit into from
May 28, 2024

Conversation

trewest
Copy link
Collaborator

@trewest trewest commented May 22, 2024

Add unit tests for the assisted agentserviceconfig resource

Needed for #295

@trewest trewest requested a review from kononovn as a code owner May 22, 2024 19:17
@trewest trewest requested a review from achuzhoy May 22, 2024 19:18
@trewest
Copy link
Collaborator Author

trewest commented May 22, 2024

/cc @achuzhoy @kononovn

Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.Please review comments above.

@kononovn
Copy link
Collaborator

@trewest Please re-base

@trewest trewest force-pushed the add-asc-unittests branch 3 times, most recently from e966c44 to be00336 Compare May 23, 2024 15:05
kononovn
kononovn previously approved these changes May 23, 2024
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kononovn kononovn merged commit 0b5663a into openshift-kni:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants