Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ztp: Remove GO111MODULE #1784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ztp: Remove GO111MODULE #1784

wants to merge 1 commit into from

Conversation

sebrandon1
Copy link
Contributor

GO111MODULE=on is the default behavior as of Go 1.16. Not needed anymore.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from ffromani and yanirq January 17, 2024 21:12
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

Hi @sebrandon1. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Member

yanirq commented Jan 17, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2024
@sebrandon1 sebrandon1 force-pushed the remove_go11module branch 2 times, most recently from ead027f to 57fda61 Compare January 19, 2024 21:08
@yanirq
Copy link
Member

yanirq commented Jan 20, 2024

/retest

@yanirq
Copy link
Member

yanirq commented Jan 21, 2024

please add ztp: as a prefix to the commit msg + PR title

@sebrandon1 sebrandon1 force-pushed the remove_go11module branch 2 times, most recently from 9a15f33 to dffc5d5 Compare January 22, 2024 16:05
@sebrandon1 sebrandon1 changed the title Remove GO111MODULE ztp: Remove GO111MODULE Jan 22, 2024
@yanirq
Copy link
Member

yanirq commented Jan 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

New changes are detected. LGTM label has been removed.

@sebrandon1 sebrandon1 force-pushed the remove_go11module branch 2 times, most recently from dd2481b to b2469e9 Compare February 1, 2024 20:00
@sebrandon1
Copy link
Contributor Author

/retest

@sebrandon1 sebrandon1 mentioned this pull request Feb 2, 2024
Open
@sebrandon1
Copy link
Contributor Author

/retest

@sebrandon1 sebrandon1 force-pushed the remove_go11module branch 3 times, most recently from c5e52e3 to e3b272c Compare February 21, 2024 14:32
@sebrandon1 sebrandon1 mentioned this pull request Mar 6, 2024
Merged
@sebrandon1 sebrandon1 force-pushed the remove_go11module branch from f6d61df to ea5f7f5 Compare June 7, 2024 16:10
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024 •
edited
Loading

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile 90b2327 link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani Awaiting requested review from ffromani

@yanirq yanirq Awaiting requested review from yanirq

Assignees

@yanirq yanirq

Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebrandon1 @yanirq