Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GO-2024-2659 (#15547) #904

Merged

Conversation

skonto
Copy link

@skonto skonto commented Oct 3, 2024

What this PR does / why we need it:

@openshift-ci openshift-ci bot requested a review from mgencur October 3, 2024 13:51
@skonto skonto requested a review from ReToCode October 3, 2024 13:51
@openshift-ci openshift-ci bot requested a review from ReToCode October 3, 2024 13:51
@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@skonto
Copy link
Author

skonto commented Oct 3, 2024

Vulnerability #1: GO-2024-3106
    Stack exhaustion in Decoder.Decode in encoding/gob
  More info: https://pkg.go.dev/vuln/GO-2024-3106
  Standard library
    Found in: encoding/[email protected]
    Fixed in: encoding/[email protected]
    Example traces found:
Error:       #1: cmd/activator/main.go:[20](https://github.com/openshift-knative/serving/actions/runs/11163315729/job/31029963944?pr=904#step:4:21)5:2: activator.main calls websocket.ManagedConnection.Shutdown, which eventually calls gob.Decoder.Decode

Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold for the go version thing

Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Author

skonto commented Oct 3, 2024

/cherry-pick release-v1.15

@openshift-cherrypick-robot

@skonto: once the present PR merges, I will cherry-pick it on top of release-v1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Oct 4, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 7b6865e into openshift-knative:release-v1.14 Oct 4, 2024
7 checks passed
@openshift-cherrypick-robot

@skonto: new pull request created: #906

In response to this:

/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants