-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE-1.11] [SRVKS-661][Backport] Support http1 full duplex per workload (#14568) #591
[RELEASE-1.11] [SRVKS-661][Backport] Support http1 full duplex per workload (#14568) #591
Conversation
/test 414-images |
It requires 1.21 on this branch too. Forgot about it.
|
* support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac
2d7da48
to
7e2eee7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
we still need the bump on S-O first.
/test 414-images |
Blocked on openshift-knative/serverless-operator#2451. Will do a PR for 1.12 as well. |
/hold for investigating unit test being flaky knative#14806 |
…#14820) * less load * limit cons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/unhold |
3df6a63
into
openshift-knative:release-v1.11
…rkload (knative#14568) (#591) (#605) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
What this PR does / why we need it:
Adds support for http1 full duplex, solves a related bug.
Which issue(s) this PR fixes:
JIRA: SRVKS-661
Does this PR needs for other branches:
YES but will do it manually as it creates a conflict.
Does this PR (patch) needs to update/drop in the future?:
JIRA: NONE