Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.8] add probes to all deployments #199

Merged

Conversation

nak3
Copy link

@nak3 nak3 commented Mar 8, 2023

This patch cherry-picks #176
However #176 contains invalid new line in domainmapping-controller.yaml so cherry-pick from upstream knative#13563

/cc @skonto @ReToCode

@openshift-ci openshift-ci bot requested review from ReToCode and skonto March 8, 2023 02:28
@nak3
Copy link
Author

nak3 commented Mar 8, 2023

/cherry-pick release-v1.9

@openshift-cherrypick-robot

@nak3: once the present PR merges, I will cherry-pick it on top of release-v1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved label Mar 8, 2023
Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 587a65c into openshift-knative:release-v1.8 Mar 8, 2023
@openshift-cherrypick-robot

@nak3: new pull request created: #203

In response to this:

/cherry-pick release-v1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants