Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Add update-deps.sh call to generate-release #1156

Open
wants to merge 2 commits into
base: release-v1.15
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1153

/assign dsimansk

@skonto
Copy link

skonto commented Feb 5, 2025

/test 417-test-e2e

@skonto
Copy link

skonto commented Feb 5, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
@skonto
Copy link

skonto commented Feb 5, 2025

validate:

no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/vendor/knative.dev/pkg/test/crd.go b/vendor/knative.dev/pkg/test/crd.go
index 941ec7c[21](https://github.com/openshift-knative/serving/actions/runs/13138143899/job/36658408217?pr=1156#step:6:22)..eb7c0e0b3 100644
--- a/vendor/knative.dev/pkg/test/crd.go
+++ b/vendor/knative.dev/pkg/test/crd.go
@@ -74,9 +74,9 @@ func CoreV1ObjectReference(kind, apiversion, name string) *corev1.ObjectReferenc
 func NginxPod(namespace string) *corev1.Pod {
 	return &corev1.Pod{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      nginxName,
-			Namespace: namespace,
-			Labels:    map[string]string{"sidecar.istio.io/inject": "true"},
+			Name:        nginxName,
+			Namespace:   namespace,
+			Annotations: map[string]string{"sidecar.istio.io/inject": "true"},
 		},
 		Spec: corev1.PodSpec{
 			Containers: []corev1.Container{
Error: Not all generated files are commited. Run `openshift/release/generate-release.sh and commit files.
Error: Process completed with exit code [33](https://github.com/openshift-knative/serving/actions/runs/13138143899/job/36658408217?pr=1156#step:6:34).

I guess we were not update to date? cc @dsimansk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants